JUL
20
2003

KStringHandler::tagURLs

Trying to fix http://bugs.kde.org/show_bug.cgi?id=60522 isn't a problem in kSirc. It's a generic problem in KStringHandler::tagURLs.

URL entries that are of the form http://url/~ or end in any none-word or none-number entry gets poorly highlighted.

Looks like the best fix is to port kdepim/libkdenetwork/linklocator is tagURLs. Better thoughts?

Comments

I think it's a god idea. I just had a look at the class. IMHO it should be moved to kdecore, either to KStringHandler, but still externally accessable or as a normal seperate class. However it should not be made private, because it provides many useful methods. Then tagURL() could use it.

Some cleanups would be needed for this class, though:

  • Add a d-pointer
  • s/getFoo()/foo()/

Sidenote: I'd really like to get rid of libkdenetwork rather soon btw. The problem with all of these classes however is that they are GPL instead lib LGPL because most have been factored out from KMail or KNode, so what's needed is to contact their respective authors first. I'd volunteer to do that. The classes should then be moved to either libkdepim or kdelibs, preferrably the first.


By Daniel Molkentin at Sun, 07/20/2003 - 18:49

The class is is good, but the class can’t do tagURLs at the moment. It converts the text to html text, instead of just searching for URLs. So it needs a few changes.

Some of the classes make no sense for libkdepim. This one for example, is searching text for URLs a pim type of operation? 


By KDE User at Sun, 07/20/2003 - 19:04

This specific class should really go into kdelibs, I was rather referring to classes like kpgp and kmime. Those make no or only limited sense in kdelibs.


By Daniel Molkentin at Sun, 07/20/2003 - 19:10

*deleted*


By KDE User at Sun, 07/20/2003 - 19:02